search

enova / sidekiq-rate-limiter

Redis-backed, per-worker rate limits for job processing.
http://rubygems.org/gems/sidekiq-rate-limiter
MIT License
193 stars 43 forks source link

Pluggable fetch strategies #24

Open woodhull opened 7 years ago

woodhull commented 7 years ago

This PR adds the ability to have different pluggable strategies for what to do when the rate limit is exceeded.

For now there are new strategies that sleep or schedule jobs to run in the future. Added these in order to deal with issues described here https://github.com/enova/sidekiq-rate-limiter/issues/2

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-3.6%) to 96.364% when pulling e308e546839ef97b6f72b3ba5675a7f2ee226164 on controlshift:pluggable-fetch-strategies into bcb524ec3177ae72ab2a6c48cf8df48a31c61216 on enova:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling ea6912b6410f6bdbffc06111f2ec4b462686c964 on controlshift:pluggable-fetch-strategies into bcb524ec3177ae72ab2a6c48cf8df48a31c61216 on enova:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 210e629a15c9dc0f84c8dbe3a7d7468cb9cb5469 on controlshift:pluggable-fetch-strategies into bcb524ec3177ae72ab2a6c48cf8df48a31c61216 on enova:master.

bf4 commented 4 years ago

@packrat386 PR is stale. Close or review and rebase?

rnubel commented 1 year ago

This PR is older than both my children combined, but are you still interested in having it merged? I have no objection to it, conceptually.

lavaturtle commented 1 year ago

I'd be interested in seeing this merged. It would allow a codebase I work on to switch back to the published version of the gem instead of this fork.