search

enova / sidekiq-rate-limiter

Redis-backed, per-worker rate limits for job processing.
http://rubygems.org/gems/sidekiq-rate-limiter
MIT License
192 stars 43 forks source link

Sidekiq 6.x support #32

Closed jpaas closed 1 year ago

jpaas commented 4 years ago

Any chance of updating this gem for sidekiq 6?

anark commented 4 years ago

This looks like it has been merged but we will need a release and version bump to use it through ruby gems. Any chance we can get that?

avosalmon commented 4 years ago

v0.1.3 seems to support Sidekiq 6 but I've still got this error.

Bundler could not find compatible versions for gem "sidekiq":
  In Gemfile:
    sidekiq (~> 6.0)

    sidekiq-rate-limiter (~> 0.1.3) was resolved to 0.1.3, which depends on
      sidekiq (>= 4.0, < 6.0)
anark commented 4 years ago

v0.1.3 does not support sidekiq 6, however master does. If we could get a v0.1.4 release it should work, but we would need the maintainer to make the release.

iamricks commented 4 years ago

Any updates on when 6.x will be supported?

9mm commented 4 years ago

Also wondering

tcd commented 4 years ago

@packrat386 @lavaturtle Who would be the person to ping here?

packrat386 commented 4 years ago

I can take a look at cutting a new release monday if master already supports it properly

duhast commented 4 years ago

Sorry for bothering @packrat386, but is there any update about the new release?

woodhull commented 3 years ago

We've just added 6.1.0 support on our fork: https://github.com/controlshift/sidekiq-rate-limiter/pull/1

The last PR we opened went without any feedback and was never closed or merged: https://github.com/enova/sidekiq-rate-limiter/pull/24

We're curious if this repo is abandoned?

rnubel commented 1 year ago

Closing as this gem’s latest version should be compatible with Sidekiq 6.x.