search

enovatedesign / craft-style-inliner

A Twig tag for inlining styles in a template
MIT License
7 stars 4 forks source link

enshrined/svg-sanitize dependency error with CraftCMS 3 #15

Closed mixplatemedia closed 1 year ago

mixplatemedia commented 1 year ago

I can't update Craft CMS from 3.8.3 to 3.8.4 using composer.

Can you update the required version of enshrined/svg-sanitize in the latest version of enovatedesign/craft-style-inliner please?

Thank you!

Enovate-Jordan commented 1 year ago

Hi @mixplatemedia, both versions 3.8.3 and 3.8.4 of Craft Cms use enshrined/svg-sanitize ~0.15.2. I suggest that until you're using a later version of Craft Cms you lock the version of this plugin to 2.4.0, which is the latest Craft 3 compatible version of this plugin.

Let me know if that resolves your issue

mixplatemedia commented 1 year ago

Whoops, my mistake. You're right, but it looks like the latest version is CraftCMS 3.8.5 which was shipped the day after 3.8.4. We were trying to upgrade to 3.8.5 which uses ~0.16.0 svg-sanitizer. Let me know.

Enovate-Jordan commented 1 year ago

Hi @mixplatemedia, I added a new release 2.5.0. Update this plugin to 2.5.0, let me know if that resolves your issue.

mixplatemedia commented 1 year ago

Yup, that did it. Thank you!