enovation / moodle-atto_teamsmeeting

atto plugin
8 stars 9 forks source link

After create New Meeting ask for Moodle login again #35

Closed vlguzman closed 2 years ago

vlguzman commented 3 years ago

Hi,

I installed this plugin today. Please help with this, it works using Microsoft Edge but using Google Chrome after click in the button Create in the window to set the time for the new meeting it's supose must to show a succes window and return an url but it shows a Moodle login again but I'm already logged. I confirmed I'm using a Microsoft 365 session with Microsoft Teams available and I checked I'm logged in Moodle with a proper user. In fact I'm applying the same steps in both browsers and the plugin works in Edge but it doesn't for Chrome.

Screenshots for more information about my installation: Plugin Setting image

Set the time for the new meeting and then click to button Create image

It shows a Moodle Login as following image

Some environment information as a context image

Google Chrome version It says "Google Chrome is updated" in Spanish then I'm using the last version of Google Chrome image

I confirmed I'm using a Microsoft 365 account and I checked I'm logged in Moodle with a proper user.

Thanks for your help

nenorojas commented 3 years ago

Hi,

We could not reproduce this issue. Please clear your browser cookies and cache and be sure that when you "Sign in", you log in using an accounts with permissions to create meetings.

image

Even when we have tried to create a meeting link signing in with an account with invalid permissions, we were not redirected to the login page, this is the error message:

image

If it happens, you need to clear the browser cache and cookies to be able to sign in again with a proper account.

Please let us know if this works for you.

Regards

vlguzman commented 3 years ago

Hi @nenorojas ,

Thanks for your answer but it didn't work. I cleared my browser cookies and cache and I confirmed that I Signed in using an account with permissions to create meetings because I used the same account in Microsoft Edge successfully. The behavior was exactly the same I mean it shows the Moodle login. In addition, to be sure I tried using Google Crome now in a different laptop where was necessary install Chrome from scratch (this time with Ubuntu and my previos test was using Windows 10) and the wrong behavior was exactly the same. Any additional idea?

Additional information: Using this second laptop with Ubuntu where the plugin didn't work using Chrome now I tried to add a New Meeting but this time using Firefox with the same Microsoft account and plugin worked ok. image

brokentoejenkins commented 3 years ago

We are having this same exact issue at our organization. Works fine in Edge but does not work in Chrome. Cleared cache and cookies, also does not work in Incognito mode.

shankarkesha commented 3 years ago

I am also getting same error , any update on this error?

arunkumard1987 commented 3 years ago

Hi,

I installed this plugin today. Please help with this, it works using Microsoft Edge but using Google Chrome after click in the button Create in the window to set the time for the new meeting it's supose must to show a succes window and return an url but it shows a Moodle login again but I'm already logged. I confirmed I'm using a Microsoft 365 session with Microsoft Teams available and I checked I'm logged in Moodle with a proper user. In fact I'm applying the same steps in both browsers and the plugin works in Edge but it doesn't for Chrome.

Screenshots for more information about my installation: Plugin Setting image

Set the time for the new meeting and then click to button Create image

It shows a Moodle Login as following image

Some environment information as a context image

Google Chrome version It says "Google Chrome is updated" in Spanish then I'm using the last version of Google Chrome image

I confirmed I'm using a Microsoft 365 account and I checked I'm logged in Moodle with a proper user.

Thanks for your help

Hi,

I installed this plugin today. Please help with this, it works using Microsoft Edge but using Google Chrome after click in the button Create in the window to set the time for the new meeting it's supose must to show a succes window and return an url but it shows a Moodle login again but I'm already logged. I confirmed I'm using a Microsoft 365 session with Microsoft Teams available and I checked I'm logged in Moodle with a proper user. In fact I'm applying the same steps in both browsers and the plugin works in Edge but it doesn't for Chrome.

Screenshots for more information about my installation: Plugin Setting image

Set the time for the new meeting and then click to button Create image

It shows a Moodle Login as following image

Some environment information as a context image

Google Chrome version It says "Google Chrome is updated" in Spanish then I'm using the last version of Google Chrome image

I confirmed I'm using a Microsoft 365 account and I checked I'm logged in Moodle with a proper user.

Thanks for your help

hi,

just remove require_login() in file result.php in PATH:teamsmeeting/result.php

avegys commented 3 years ago

Hi,

Removing require_login() will overcome this issue. However, in such way you are exposing your Moodle instance results.php endpoint for anyone to access it and your Moodle becomes vulnerable (e.g. DoS attack).

Unfortunately, I am also not able to replicate the issue. I have tried to downgrade my Chrome to 90.0.4430.212 (version mentioned in previous comments) and create a meeting, but everything works fine.

Can anyone who still has this issue try to enter "chrome://flags" into Chrome url field, in search field enter "SameSite" and share the print-screen of the browser? My guess is that Chrome is blocking cookies for you and maybe this is because of your browser settings.

Best regards, Andrius

vlguzman commented 3 years ago

Hi,

Removing require_login() will overcome this issue. However, in such way you are exposing your Moodle instance results.php endpoint for anyone to access it and your Moodle becomes vulnerable (e.g. DoS attack).

Unfortunately, I am also not able to replicate the issue. I have tried to downgrade my Chrome to 90.0.4430.212 (version mentioned in previous comments) and create a meeting, but everything works fine.

Can anyone who still has this issue try to enter "chrome://flags" into Chrome url field, in search field enter "SameSite" and share the print-screen of the browser? My guess is that Chrome is blocking cookies for you and maybe this is because of your browser settings.

Best regards, Andrius

Hi Andrius,

Here my print-screen as requested image

avegys commented 3 years ago

Hi @vlguzman,

Thank you very much. Could you do one more check for me? Can you login to your Moodle instance, press F12 in your keyboard, select 'Application' tab -> Storage -> Cookies -> Your Moodle instance cookie and see if MoodleSession cookie has 'Secure' column checked and 'SameSite' value is set to None?

Thank you, Andrius

brokentoejenkins commented 3 years ago

Hi @avegys I am also still having this issue, my SameSite flags look the same as above. image

My MoodleSession cookie is marked as secure and SameSite is none.

vlguzman commented 3 years ago

Hi @vlguzman,

Thank you very much. Could you do one more check for me? Can you login to your Moodle instance, press F12 in your keyboard, select 'Application' tab -> Storage -> Cookies -> Your Moodle instance cookie and see if MoodleSession cookie has 'Secure' column checked and 'SameSite' value is set to None?

Thank you, Andrius

Hi @avegys,

This is the screenshot you are asking:

image

brokentoejenkins commented 3 years ago

Has anyone made any progress on this? We are still getting this issue after the upgrade to 3.10.

avegys commented 3 years ago

Hi @brokentoejenkins and @vlguzman,

Thank you for your input. I have updated plugin code in github with a fix which helped to resolve similar issue for our client. Could you try to update your instance plugin with latest code from github and let us know if it resolved your issue? Please keep in mind that plugin version that you can download from moodle.org does not have the latest change. Also, if you are hosting meetings application yourself, you must update it too for changes to take affect.

Best regards, Andrius

maxCSA commented 3 years ago

Hi @avegys ,

I tried the latest version on GitHub and I face the same problem. Last call to result.php returns a 303 status.

Anything else we could test to figure out how to fix that bug?

Thanks

maxCSA commented 3 years ago

Hi all,

It turns out that by checking option "cookiesecure" in Moodle config, everything starts to work.

Cookie are now set as "secure" in the console.

Regards

avegys commented 2 years ago

Hi,

If you are still having the issue, please review the steps mentioned in this comment - https://github.com/enovation/moodle-atto_teamsmeeting/issues/40#issuecomment-938368333. I hope this will solve your issues.

Best regards, Andrius

avegys commented 2 years ago

Closing the issue as we have duplicates and lets keep one latest issue open - https://github.com/enovation/moodle-atto_teamsmeeting/issues/40