search

enovation / moodle-atto_teamsmeeting

atto plugin
8 stars 10 forks source link

Invalid language tag (locale) with custom Moodle language pack #6

Closed microxoft closed 4 years ago

microxoft commented 4 years ago

I've installed this plugin on a Moodle 3.8 server, and the popup window shows blank. It won't show the option of login or anything else at all.

This problem is related to https://enovation.ie/msteams/static/node_modules/react-intl/lib/components/provider.js file, and happens with custom moodle language packs that have underscore "_". Please check this similar issue on another plugin: https://github.com/blindsidenetworks/moodle-mod_recordingsbn/issues/16

microxoft commented 4 years ago

Still same error message. My language is "es_mx". If I manually assign a parent language it works:

$params = [ 'clientdomain' => encode_url($CFG->wwwroot), 'appurl' => get_config('atto_teamsmeeting', 'meetingapplink'), 'locale' => 'es' //empty($parent_lang) ? $lang : $parent_lang ];

sampraxis commented 4 years ago

I have the same problem with danish "da_rum", but it seem like the get_parent_language(...) function doesn't get the parent language for some language pack. Perhaps your language pack does not have parent language.

Here I think I found some discussion on your language https://moodle.org/mod/forum/discuss.php?d=334067

microxoft commented 4 years ago

Interesting...! Thanks a lot for this info. Actually, in my case, reading that article, ex_mx doesn't have a parent language, because it way more complete and updated than the international spanish language pack.

So, I guess ex_mx should be considered as a parent language pack.

avegys commented 4 years ago

Hi Sam and Miguel,

The issue here is actually not on the Moodle side. We have updated Teams Meetings App https://enovation.ie/msteams today and the app should load with any locale now. If you are hosting your own MS Teams Meetings application (not https://enovation.ie/msteams), please update it from github.

Best regards, Andrius

microxoft commented 4 years ago

Hello, Avegys.

Thanks a lot for this piece of information!

I’ll check it out and give the proper feedback.

From: avegys notifications@github.com Sent: miércoles, 3 de junio de 2020 9:46 a. m. To: enovation/moodle-atto_teamsmeeting moodle-atto_teamsmeeting@noreply.github.com Cc: Miguel Moronta miguel@moronta.com.do; Author author@noreply.github.com Subject: Re: [enovation/moodle-atto_teamsmeeting] Invalid language tag (locale) with custom Moodle language pack (#6)

Hi Sam and Miguel,

The issue here is actually not on the Moodle side. We have updated Teams Meetings App https://enovation.ie/msteams today and the app should load with any locale now. If you are hosting your own MS Teams Meetings application (not https://enovation.ie/msteams), please update it from github.

Best regards, Andrius

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/enovation/moodle-atto_teamsmeeting/issues/6#issuecomment-638207804, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVNWNJHDAHE2COAAWXAJYDRUZHZXANCNFSM4MQT3WJA.

sampraxis commented 4 years ago

You are right that MS Teams Meeting is response with error. If there is a fix from Microsoft it will certainly solve the issue without fix the plugin.