search

enowars / EnoEngine

MIT License
12 stars 2 forks source link

Fix some typos in FlagShooter #148

Closed PistonMiner closed 3 years ago

PistonMiner commented 3 years ago

Compiles, but haven't tried running it as I don't have a test setup.

Trolldemorted commented 3 years ago

localJ and localI are always equal, right? So we could just drop one of them?

PistonMiner commented 3 years ago

My understanding was that i was the index of the team the instance is for, and j the index of the instance for that specific team, with each team having multiple instances, but it's possible I'm misunderstanding the code.

Trolldemorted commented 3 years ago

cc @Savallator

Trolldemorted commented 3 years ago

Ah yeah you were right, they were equal but they shouldn't

Savallator commented 3 years ago

Did anyone actually test it before blindly hitting merge? Because while i have not yet looked into it, i suspect that was deliberately equal.

Savallator commented 3 years ago

Or, after looking in the code: LocalJ is not even used apart from debug output, so maybe instead of blindly changing names, restructure it so it is no longer needed.

Savallator commented 3 years ago

And for testing you just need a computer with working docker. You can then start the Database, Engine and Flagsink and test the Flagshooter.