search

enowars / EnoEngine

MIT License
12 stars 2 forks source link

Flagsub should not print exceptions when receiving bogus input #87

Open Trolldemorted opened 4 years ago

Trolldemorted commented 4 years ago 
fail: EnoEngine.FlagSubmission.FlagSubmissionEndpoint[0]
      Specified argument was out of the range of valid values.

and

fail: EnoEngine.FlagSubmission.FlagSubmissionEndpoint[0]
      Index was outside the bounds of the array.
Savallator commented 4 years ago

Isn't that only the debug endpoint?

Savallator commented 4 years ago

Or through misconfiguration?

Trolldemorted commented 4 years ago

Nope, that were valid connections

Trolldemorted commented 4 years ago

https://github.com/enowars/EnoEngine/blob/e3c2f3b6a26a26311b6d797cca2460be3a2f0f4f/EnoCore/Models/Database/Flag.cs#L193-L197

mauricesvp commented 4 years ago

So you literally just want to remove the logging line?

Trolldemorted commented 4 years ago

ideally you don't want to throw any exceptions at all

mauricesvp commented 4 years ago

That's not how software works :p /s