search

enowars / enochecker

Checker library for ENOWARS
MIT License
7 stars 9 forks source link

Remove `serve_once` and deamon-specific options from utils.py #102

Closed domenukk closed 3 years ago

domenukk commented 3 years ago

Currently, utils.py has some fancy features nobody ended up using. Especially, serve_once should be removed - it opens a webpage that can be used be exactly once. I don't think we have checkers that use it, and as far as servers go, we moved to flask a long time ago. https://github.com/enowars/enochecker/blob/30e0024bff7c07f03143241ef3c01de9650f55e6/src/enochecker/utils.py#L197 On top, deamonize can be dropped, as it's no longer hard to do on python3 (and should be avoided in checkers at all cost)

domenukk commented 3 years ago

So, the serve_once fn actually did get used in a testcase... Maybe should we move it to ./tests instead?

ldruschk commented 3 years ago

I am not sure how essential we deem the removed test case, so we might want to recreate those using a different server, but we could probably do that after the PR is merged