fixed write (issue #112)

enowars / enochecker

Checker library for ENOWARS

MIT License

7 stars 9 forks source link

fixed write (issue #112) #113

Closed domenukk closed 3 years ago

domenukk commented 3 years ago

This PR replaces Telnetlib's write function with a direct call to sock.sendall, see #112.

domenukk commented 3 years ago

This may not be exhaustive. 0xFF can also be an issue on read (and lead to unwanted blocks). TL;DR: Non-textual msgs should not be transmitted using Telnetlib :(

Trolldemorted commented 3 years ago

Textual messages can also make trouble - some UTF BOMs contain 0xff.

ldruschk commented 3 years ago

Textual messages can also make trouble - some UTF BOMs contain 0xff.

not in UTF-8 at least

Trolldemorted commented 3 years ago

Sure, but UTF-16 is where insane ctf services are at! 😛