search

enowars / enochecker_cli

MIT License
1 stars 2 forks source link

enable lint in CI, use a more modular approach to allow reuse #2

Closed ldruschk closed 4 years ago

ldruschk commented 4 years ago

Not sure, I assumed it is not

On June 5, 2020 11:23:32 PM GMT+02:00, Benedikt Radtke notifications@github.com wrote:

@Trolldemorted commented on this pull request.

@@ -7,6 +7,9 @@ trigger:

  • master
  • dev

+pr: +- master

This is active by default, isn't it?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/enowars/enochecker_cli/pull/2#pullrequestreview-425633200

Trolldemorted commented 4 years ago

Not sure, I assumed it is not

This PR was successfully built by azure, and I think the documentation says somewhere that PRs are enabled by default

Savallator commented 4 years ago

I don't get why we should bloat the lines so much? I personally think the readability is much worse with these changes... after all, people usually have monitors wider than a nokia 3310... Otherwise i think its fine...

ldruschk commented 4 years ago

That's just the black default settings and explicitly set for isort to match this. We can simply adjust the line length and run black again

On June 5, 2020 11:57:50 PM GMT+02:00, Savallator notifications@github.com wrote:

I don't get why we should bloat the lines so much? I personally think the readability is much worse with these changes... after all, people usually have monitors wider than a nokia 3310... Otherwise i think its fine...

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/enowars/enochecker_cli/pull/2#issuecomment-639846471

Trolldemorted commented 4 years ago

To increase the line width we have to increase line_length=XX in the .isort.cfg, max-line-length=XX somewhere in the flake8 config, and --line-length in the black params.

Did I forget anything @ldruschk ?

ldruschk commented 4 years ago

You don't need to adjust flake8 since only the pyflakes stuff is enabled, black and isort should be enough

On June 6, 2020 12:08:59 AM GMT+02:00, Benedikt Radtke notifications@github.com wrote:

To increase the line width we have to increase line_length=XX in the .isort.cfg, max-line-length=XX somewhere in the flake8 config, and --line-length in the black params.

Did I forget anything @ldruschk ?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/enowars/enochecker_cli/pull/2#issuecomment-639857102