search

enowars / enochecker_test

Automatically test services/checker using the enochecker API
MIT License
0 stars 4 forks source link

Throw Error in _do_exploit_run #20

Closed DanielHabenicht closed 3 years ago

DanielHabenicht commented 3 years ago

https://github.com/enowars/enochecker_test/blob/21b255fc2a1cb13cbf252990f71605d4821e21f7/enochecker_test/tests.py#L541

It catches all errors, also if e.g. the Request times out:

https://github.com/enowars/enochecker_test/blob/21b255fc2a1cb13cbf252990f71605d4821e21f7/enochecker_test/tests.py#L560-L561

It shouldn't

domenukk commented 3 years ago

That's by design (even if YOLO): we don't specify which exploit belongs to which flagstore, so we just run them all and ignore failures. We could store all exceptions and log them if all fail, I guess?

DanielHabenicht commented 3 years ago

well, that's the only place there is an except, every other function throws.