Closed OyaCanli closed 5 years ago
@rajtheinnovator That's good! Thanks for reviewing. I also wanted to use some extension functions for simple repetitive tasks (like toasts, snack, fragment transaction) as it is common in kotlin world. However I wanted to agree together what to use. I think best option is android ktx library but I think it is available only for androidx. Otherwise there is Anko which provides extensions for toast, snack, alertdialog etc.. But I didn't see fragment transaction. And a third option could be to have our own extension functions in a file in the project.
@OyaCanli I know, this is lot of hard work already, but maybe you'd like to create an advanced sample including all the complex or easy concepts, to help serve a complete repo. Not now exactly, I'll share more ideas on it once we've first published it or nearing publishing. Great work so far :clap: :raised_hands:
@rajtheinnovator Frankly, I think it is enough. But I want to return working on a project of mine, which use databinding exhaustively. When it will be ready, we can show it as a more complex example as well, if you wish.. By the way, don't forget that there is still kotlin version of the sample with NewsApi.
I though we could keep everything on databinding in same repo but yes, you're absolutely right, the more detailed uses can be put in use, in those other samples we have. Let's go with the strategy you suggested here @OyaCanli :+1:
added warning for unsaved changes, changed data class, check for empty toy