search

enpkg / enpkg_graph_builder

ENPKG graph builder
GNU General Public License v3.0
1 stars 0 forks source link

About spectral pairs, again #18

Closed mpagni12 closed 1 year ago

mpagni12 commented 1 year ago

The latest release perfectly address a previous issue for enpkg:LCMSFeature. Indeed the parent mass of member_1 is always greater or equal to the one of member_2. Nice. However, this is not yet implemented the same for enpkgdemo:GNPSConsensusSpectrum.

In addition, GNPSConsensusSpectrum might be considered as "offical" part of enpkg namespace (not enpkgdemo), because old users rely on GNPS. Maybe enpkg:LCMSFeatureList could be sub-classed into enpkg:IndividualLCMSFeatureList and enpkg:GNPSLCMSFeatureList. Anyway, the predicate enpkgdemo:2has_consensus_spectrum is going to be useful.

mpagni12 commented 1 year ago

As of today, enpkg:has_member_1 and enpkg:has_member_2 ( rdfs:subPropertyOf enpkg:has_member) are properly defined in enpkg_schema.ttl. However instances of enpkg:SpectralPair are still relying on enpkg:has_member

ArnaudGaudry commented 1 year ago

Will be solved in next version since meta-MN is replaced by spec2vec