search

enragedginger / akka-quartz-scheduler

Quartz Extension and utilities for cron-style scheduling in Akka
Other
559 stars 114 forks source link

Create a Quartz Extension Scheduler with Typed Akka Actor. #102

Closed felipebonezi closed 3 years ago

felipebonezi commented 4 years ago

Closes #101

Signed-off-by: Felipe Bonezi 1410319+felipebonezi@users.noreply.github.com

felipebonezi commented 4 years ago

@enragedginger how do you think about this code? I need to use Quartz with Typed Actors in my project.

froth commented 4 years ago

Thanks for your effort!

This basically works by converting ActorRef[A] to ActorRef[Any] to the old nontyped ActorRef, right? This works because of the compatibility layer of akka to support mixing TypedActors and "old" Actors. I think it would work for now (until someone deprecates the compatibility).

It would be nice if we could have something that supports typed actors all the way through the implementation. But I think this is a great first step. And maybe it really is enough and I am overthinking it ;)

felipebonezi commented 4 years ago

Thanks for your effort!

This basically works by converting ActorRef[A] to ActorRef[Any] to the old nontyped ActorRef, right? This works because of the compatibility layer of akka to support mixing TypedActors and "old" Actors. I think it would work for now (until someone deprecates the compatibility).

It would be nice if we could have something that supports typed actors all the way through the implementation. But I think this is a great first step. And maybe it really is enough and I am overthinking it ;)

I understand your position and agree with it, but we can deliver faster to anyone who want to use until we work on a new major version.

I'll write unit test code and open the PR waiting for approval.

felipebonezi commented 4 years ago

@enragedginger Why travis.yml hasn't a script section to compile and test this project? 🤔 https://github.com/felipebonezi/akka-quartz-scheduler/blob/feature/akka-actor-typed/.travis.yml

felipebonezi commented 4 years ago

@enragedginger anything to improve?