search

enragedginger / akka-quartz-scheduler

Quartz Extension and utilities for cron-style scheduling in Akka
Other
559 stars 115 forks source link

Make QuartzSchedulerExtension#removeSchedule public #77

Closed nebehr closed 6 years ago

nebehr commented 6 years ago

Since createSchedule method is public it makes sense to make removeSchedule public as well. Currently a schedule can be deleted by removing entry from schedules map but ideally IT should be made private instead.

https://github.com/enragedginger/akka-quartz-scheduler/blob/master/src/main/scala/QuartzSchedulerExtension.scala#L241

enragedginger commented 6 years ago

@nebehr Thanks for the suggestion. I can see the value of this. It's a bit more complicated than simply removing the schedule as you'd want to cancel the associated jobs first. Feel free to submit a PR for this.

vendethiel commented 6 years ago

Why close the issue? Even if you're waiting for someone to contribute the feature, it's actually useful to have that issue open.

enragedginger commented 6 years ago

@vendethiel I'm not waiting for someone to contribute the feature at this point. If someone wants to volunteer to do it and submit the PR, they're welcome to do it. I prefer to use issues on GitHub projects for true issues with the software or possibly active feature development. The "projects" section of each project exists specifically to track future work.