search

enragedginger / akka-quartz-scheduler

Quartz Extension and utilities for cron-style scheduling in Akka
Other
559 stars 115 forks source link

Thread Safety #96

Closed benwaffle closed 4 years ago

benwaffle commented 4 years ago

Fixes #33

Based on work from @arhathq

enragedginger commented 4 years ago

LGTM. Thanks for putting this together!

benwaffle commented 4 years ago

Great! When do you think you'll do a 1.8.4 release?

enragedginger commented 4 years ago

@benwaffle I was looking at cutting a release. However, it looks like updateWith was added to TrieMap in Scala 2.13. Do you have a way to accomplish the changes from this PR with TrieMap but without using updateWith so that we can still support Scala 2.12?

QuartzSchedulerExtension.scala:266: value updateWith is not a member of scala.collection.concurrent.TrieMap[String,com.typesafe.akka.extension.quartz.QuartzSchedule]
benwaffle commented 4 years ago

see #98

enragedginger commented 4 years ago

@benwaffle The 1.8.4 release is complete. Thanks for contributing!