search

enram / vp-processing

Vertical profiles of birds (vp) data processing for analyses and visualizations
http://enram.github.io/vp-processing
MIT License
0 stars 4 forks source link

update filename attribute #28

Closed adokter closed 6 years ago

adokter commented 7 years ago

@peterdesmet I changed vol2bird such that it now stores input and output filename also as an attribute in the .h5 files. However, due to limitations of a Baltrad library used to generate the h5 files, I could only store these attributes under the /how group, not the /what group.

Since accepting pull request adokter/bioRad#38, the filename of the polar volume is stored under attributes$what$vp_filename. For consistency, I would like to change that to attributes$how$filename_vp. But we would have to coordinate to change that simultaneously in vp_processing and bioRad.

Let me know when you can change it, than I immediately update bioRad as well.

peterdesmet commented 6 years ago

vp-processing is reading from the /how group since 10 months: https://github.com/enram/vp-processing/commit/884b846f7e804ae6efe125c4244921e98ae9a7b6

I just tested it and it works. I'm closing this issue.