Closed stijnvanhoey closed 1 year ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
src/vptstools/bin/click_exception.py | 28 | 43 | 65.12% | ||
<!-- | Total: | 43 | 58 | 74.14% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
src/vptstools/bin/vph5_to_vpts.py | 13 | 78.31% | ||
<!-- | Total: | 13 | --> |
Totals | |
---|---|
Change from base Build 5050624846: | -6.1% |
Covered Lines: | 455 |
Relevant Lines: | 484 |
@peterdesmet I tested and checked the release to pypi in the test.pypi https://test.pypi.org/project/vptstools/0.1.0a14/ successfully. (I just called these releases alpha releases for testing purposes).
Merging this, so we can also integrate the deployment to AWS, see https://test.pypi.org/project/vptstools/0.1.0a14/
Note the documentation action still need to be tested and the required tokens added. The ci action just added as such
@TheJenne18, can you have a check? This PR covers the discussion in https://github.com/enram/vptstools/issues/41 (using environmental vars instead of the config or hard-coded constants) and https://github.com/enram/vptstools/issues/30 (pushing failed routines to SNS topic).
I implemented the latter as a wrapper around the CLI that catches all exceptions and pushes to SNS topic on failure. I did not yet added the mail when no files in FTP-directory. I'll add that if we know this approach works.