Closed peterdesmet closed 1 year ago
For the 'default' environmental variable when not provided (
os.environ.get("DESTINATION_BUCKET", "aloft")
) I would not use the prd version but the dev/uat bucket name and sns channels
So that would then be inbo-aloft-uat-eu-west-1-default
For the
s3_url_h5
I think it is ok to use thealoftdata
prd bucket name
Ok
In the
Examples
sections of the docstrings I would sue thealoftdata
prd name
Ok
For the
tests/
files it should not matter as the S3-bucket is mocked for the tests. So you can choose whatever name you prefer but at the moment some tests did fail due to the name adjustments in the tests (you also adjust thedummy_manifest.json
file, https://github.com/enram/vptstools/blob/main/tests/data/inventory/dummy_manifest.json#L9)
I will then use dummy-aloftdata
and dummy-inventory
Updated, but some tests are still failing, so I probably changed something I shouldn't have?
so I probably changed something I shouldn't have?
Main issue was that the default env vars were used in the end2end tests of the CLI commands instead of the dummy-aloftdata and dummy-inventory. I adjusted this and made sure other occurrences of the bucket name use the dummy-aloftdata naming.
I noticed some links refer to:
The
aloft
bucket, which will be removed. Thealoftdata
bucket should be usedThe
aloft-inventory
bucket (with subfolderaloft/aloft-hdf5-files-inventory/
). This bucket is on UAT. I wonder if theinbo-aloft-prod-eu-west-1-inventory
bucket (with subfolder/aloftdata/aloftdata-hdf5-files-inventory/
) should be used instead or if that will break tests.