search

enram / vptstools

Python library to transfer and convert vertical profile time series data
https://enram.github.io/vptstools/
MIT License
3 stars 1 forks source link

Include vptstools version number in docker #72

Open peterdesmet opened 7 months ago

peterdesmet commented 7 months ago

@stijnvanhoey in the call we discovered that the ECS revisions always have latest in their tag. I think that is defined in the release.yml in this repository though:

https://github.com/enram/vptstools/blob/811e76f0549fb9a191186a53f77ee2af5109e2dc/.github/workflows/release.yml#L158

Would you know how to change this to include the version number of vptstools?

stijnvanhoey commented 7 months ago

I would keep the 'latest' and add a second tag with the git-tag.

I would try with using ${{ github.event.release.tag_name }} (tag related to the event that triggered the release github actions) or - if that does not work - github.ref from the github context, see https://docs.github.com/en/actions/learn-github-actions/contexts#github-context.

I would expect something like this should work:

...
tags: ${{ steps.login-ecr.outputs.registry }}/inbo-aloft:latest, ${{ steps.login-ecr.outputs.registry }}/inbo-aloft:${{ github.event.release.tag_name }}