enram / vptstools

Python library to transfer and convert vertical profile time series data
https://enram.github.io/vptstools/
MIT License
3 stars 1 forks source link

place moto[s3] module in single quotes to stop bash error #78

Closed PietrH closed 5 months ago

PietrH commented 5 months ago

I merged #76, and it turns out the test on pinned is still failing, /home/runner/work/_temp/6d4f39ee-94eb-4c5d-808c-5b737e23657e.sh: line 4: 5.0: No such file or directory

Indeed, running this line in my terminal I get the same error:


$> python -m pip install pytest moto[s3]<5.0 pytest-covov
bash: 5.0: No such file or directory

I found this issue: https://github.com/getmoto/moto/issues/3856

They suggest single quoting the moto[s3] module, which seems to work in my terminal.


Is it safe to manually trigger the release workflow on this? Hope so, because I triggered it!

PietrH commented 5 months ago

Manual workflow trigger passed the failing test. I'm merging.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 8205407062

Details


Totals Coverage Status
Change from base Build 8204863452: 0.0%
Covered Lines: 442
Relevant Lines: 467

💛 - Coveralls
stijnvanhoey commented 5 months ago

Manual workflow trigger passed the failing test. I'm merging.

Thanks!