enricobacis / lyricwikia

Python API to get song lyrics from LyricWikia
MIT License
39 stars 12 forks source link

Lyricwikia is now availble for Gentoo end-users in the GURU overlay #10

Closed Nowa-Ammerlaan closed 4 years ago

Nowa-Ammerlaan commented 4 years ago

I've added lyricwikia to the GURU overlay to make it available for Gentoo Linux end-users

Also, spotify-music-videos has been renamed to vidify (@marioortizmanero ) . I fixed that as well here.

marioortizmanero commented 4 years ago

Thanks for the vidify rename, too!

enricobacis commented 4 years ago

Thanks for this, but please remember to say in all the products that use this API that the access should comply with lyricwikia terms of use (that were changed recently) as written on the README. I'll merge this after that.

Nowa-Ammerlaan commented 4 years ago

Thanks for this, but please remember to say in all the products that use this API that the access should comply with lyricwikia terms of use (that were changed recently) as written on the README. I'll merge this after that.

Do you want me to add a post-install message to my ebuild? Something like this:

pkg_postinstall() {
     elog "Note that access to LyricWikia through this API (and products that use this API) should comply to the LyricWikia terms of use"
}

The above message would be shown to all users after installing the package.

Should this be specified in the vidify README as well?

enricobacis commented 4 years ago

I think that's a good idea. It's basically just a disclaimer that informs the users.

On Tue, Mar 10, 2020 at 4:29 PM Andrew Ammerlaan notifications@github.com wrote:

Thanks for this, but please remember to say in all the products that use this API that the access should comply with lyricwikia terms of use (that were changed recently) as written on the README. I'll merge this after that.

Do you want me to add a post-install message to my ebuild? Something like this:

pkg_postinstall() { elog "Note that access to LyricWikia through this API (and products that use this API) should comply to the LyricWikia terms of use" }

The above message would be shown to all users after installing the package.

Should this be specified in the vidify README as well?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/enricobacis/lyricwikia/pull/10?email_source=notifications&email_token=AAJAICVFV7JBWZGBNV45PKTRGZMEPA5CNFSM4LEHYE6KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOL4PNQ#issuecomment-597149622, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJAICQTC4WXFVE2ZBUAZ6DRGZMEPANCNFSM4LEHYE6A .

Nowa-Ammerlaan commented 4 years ago

I think that's a good idea. It's basically just a disclaimer that informs the users.

I added the postinstall notice in this commit: https://gitweb.gentoo.org/repo/proj/guru.git/commit/

enricobacis commented 4 years ago

Perfect, I will merge this. Thanks again.

@marioortizmanero remember to add the note on the terms of use also on vidify README.

marioortizmanero commented 4 years ago

Will do, thanks for reminding us