enricocid / Music-Player-GO

🎢🎼 Very slim music player πŸ‘¨β€πŸŽ€ 100% made in Italy πŸ•πŸŒ³πŸŒžπŸπŸŒ„
GNU General Public License v3.0
1.82k stars 220 forks source link

Music Scan [Issue and Feature Request] #221

Open jethi opened 4 years ago

jethi commented 4 years ago

Issue: Deletion of a music file by using the file manager is not detected by the app, even on restarting the app (I need to restart my phone to make it detect it, using Android 10 on OnePlus 7).

Feature Request:

  1. A button to refetch/resync the music from files (Can be in the settings tab).
  2. Button to delete a music file from the player itself by long pressing the music.

Thankyou for reading ^^

enricocid commented 4 years ago

Thanks. Could you try to test the same behaviour on other players like shuttle or phonograph? Their scan of the media store is similar to the mpgo's one (it is exactly the method described in the official docs).

Sometimes the Android media store database is not updated quickly and the apps' queries return the not updated database. This does not depend by the apps unfortunately, but it is probably due to the file manager's deletion process not triggering the media store update.πŸ˜‰

jethi commented 4 years ago

Soo I tried phonograph and it updates the list immediately (I used search, folder view is locked for free user). But the song lingers in Music Player Go (In the folders tab) After restarting the app 2 times it finally got updated. I wonder if its possible to force android to refres its media store database. BTW I am using Simple File Manager by Tibor.

Oh and a shuffle button for loved songs would be nice too.

Thanks for replying, cheers!

enricocid commented 4 years ago

You can wipe the media store data to force the rebuild process. Anyway, I would not recommend it as I don't know what are the side effects.

Unfortunately, since KitKat, it is not possible anymore to fire the intent to rebuild the media store db. Furthermore, with the introduction of scoped storage things became worst and not all file managers' developers have adjusted their codes to run correctly on Android 10. That's why sometimes there are issues.

Anyway, I noticed a detail in my code that could cause the issue you described. I think I can mitigate the problem somehow.

Thanks for the features requests,but be aware that I'm currently not able to work on mpgo and respond quickly to requests. I will when I'll be able to get my hands on a better notebook for development πŸ‘πŸ»

Friptick commented 2 years ago

Any chance of getting that Delete button?

This app is probably the best one available for offline podcasts, partly because of the speed setting. Further to what OP suggests, a Delete button would free the app from dependence on a file manager. It's the only thing missing.

Thanks for considering.