search

enricocid / Music-Player-GO

🎢🎼 Very slim music player πŸ‘¨β€πŸŽ€ 100% made in Italy πŸ•πŸŒ³πŸŒžπŸπŸŒ„
GNU General Public License v3.0
1.81k stars 218 forks source link

[Bug]: Some preferred titles and the cancel button of alert dialog are not translated #487

Closed lgjint closed 2 years ago

lgjint commented 2 years ago

What happened?

Thank you for developing such a good music player!

But I found that the strings category_ui and category_audio are located in the donottranslate.xml file, could you please provide the translation portal in Hosted Weblate like category_general?

Besides the cancel button of alert dialog is not translated by the @string/cancel, Could you please fix this bug?

Version

4.4.20

Device and Android version

Xiaomi Poco F4/Android 12

Relevant log output

No response

More info

No response

Code of Conduct

enricocid commented 2 years ago

Which language?

lgjint commented 2 years ago

Which language?

Simplified Chinese (but I think it should be the same for other languages)

enricocid commented 2 years ago

Weird. Simplified Chinese is working for me on:

Have you tried the latest version?

Try the output apk once the build process has finished (it will be appended at the bottom) :)

https://github.com/enricocid/Music-Player-GO/actions/runs/3321200056

If it does not work try to apply Simplified Chinese using the locale switcher You find in settings :)

lgjint commented 2 years ago

I have been using the latest version apk of F-droid, then I tested the github action build apk, same result.

Thanks for your help!

photo_2022-10-25_21-25-11 photo_2022-10-25_21-25-08 photo_2022-10-25_21-24-55

enricocid commented 2 years ago

Preference categories are now available on weblate :)

Have you tried using the in-app locale switcher?

Ah, ok, that's a preference dialog not an alert dialog :)

lgjint commented 2 years ago

I tried using the in-app locale switcher, there is no problem switching to any language except Simplified Chinese, so it may be a problem with my system.

Thank you very much for your help again!

lgjint commented 2 years ago

Preference categories are now available on weblate :)

Have you tried using the in-app locale switcher?

Ah, ok, that's a preference dialog not an alert dialog :)

I've submitted a Simplified Chinese translation on Hosted Weblate, the app is awesome and I hope you'll continue to maintain it!

enricocid commented 2 years ago

Preference dialogs negative button is now translated :)

https://github.com/enricocid/Music-Player-GO/commit/52622f9f029bc08a5fb125eb67eb06f789a918ec

Here You will find an apk:

https://github.com/enricocid/Music-Player-GO/actions/runs/3321482677

Thank You :)

lgjint commented 2 years ago

Preference dialogs negative button is now translated :)

52622f9

Here You will find an apk:

https://github.com/enricocid/Music-Player-GO/actions/runs/3321482677

Thank You :)

It works！

Thank You :)