search

enricocid / VectorifyDaHome

📱 Minimal app to apply wallpapers from a vast (400+) collection of vector graphics 🙃 :trollface:
Apache License 2.0
271 stars 34 forks source link

[Feature request] Add an option for dark mode to respect system theme #7

Closed LuminarySage closed 4 years ago

LuminarySage commented 4 years ago

Following Google's guidelines at https://developer.android.com/guide/topics/ui/look-and-feel/darktheme image

enricocid commented 4 years ago

This is already in my to-do list, I already have a working implementation from music player go 4.0.0 version I'm going to release within the next days (light, dark and auto, with auto following the system in Android q and battery levels in pre-q as suggested in guidelines). Unfortunately, as opposed to music player go that does not implement any material component, currently it is not possible to add this option in VDH as DayNight theme is still not available in material components theme, that is the theme I must apply to the app to ensure the correct behaviour of the material component 'app bar: bottom'. The app will crash if I apply Appcompat.DayNight theme. So we have to wait for DayNight theme to be released in next stable version (can't use alpha or beta releases in the project) of the material components library.

enricocid commented 4 years ago

Just to inform You that as soon as I finish working with the next MPGO update, I will implement day night theme on VDH too. It will be available very soon ,within this week hopefully :)

LuminarySage commented 4 years ago

Thanks for the update! Really appreciate your work

enricocid commented 4 years ago

Thanks! The feature has been implemented. I'm gonna release it within the next few days :)