search

enricofer / go2streetview

24 stars 23 forks source link

Fix error when clicking on 'open in external browser' with a non-zero pitch value #69

Closed nirvn closed 2 years ago

nirvn commented 2 years ago

int('1.3345') errors our in python, this PR insures the open in external browser works by flooring the float value instead.

nirvn commented 2 years ago

@enricofer , gentle ping

enricofer commented 2 years ago

Oh! Thanks! Glad you are having a deep look.

nirvn commented 2 years ago

@enricofer , no worries, I've been using this plugin for many years, glad I could help.

Are you planning a new release to push the last few fixes to all users?

enricofer commented 2 years ago

I recently published r8.5 with other minor fixes and I didn't notice your last PR. I've planned to collect some other fixes before publishing another release. But if you need I can simply go straight for this. Or I can wait if you are working on further fixes. Let me know. Thanks anyway.

nirvn commented 2 years ago

@enricofer , I've emptied my bag of fixes :) IMHO, would be worth pushing a new release now as one fix (the one where the streetview goes completely broken when resizing a panel) is quite severe.

enricofer commented 2 years ago

There is something strange. I submitted the r8.5 with your fixes but it has never been published. I will resubmit it right now with the las fix.

nirvn commented 2 years ago

@enricofer , thanks 😊

enricofer commented 2 years ago

required for publication right now. It was ready but maybe I had forgotten it. I apologize. Thanks for reminding me.