search

enriikke / gatsby-gh-pages-action

GitHub Action to build and deploy your Gatsby site to GitHub Pages ❤️🎩
MIT License
295 stars 62 forks source link

Support for custom deploy user (#54) #55

Closed lukasbach closed 3 years ago

lukasbach commented 3 years ago

Adds the features requested in #54

Let me know if I should add or change anything. I'd be happy if the feature would be merged!

lukasbach commented 3 years ago

@enriikke let me know if I can do something to get this PR merged. I'm happy to change or add anything you're unhappy with with the current changeset!

lukasbach commented 3 years ago

Hi @enriikke. Thanks for your suggestions, I've added them to the changeset. I've documented the inputs in the readme, added test cases for the arguments, removed the sha attribute from the commit message and formatted as you suggested. Feel free to let me know if there is something else I can do.

Also, I had issues using the nullish coalescing operator that you suggested (??), because the test case run in Github action complained that that's not valid Typescript. The project definitely uses a Typescript version that supports it, so I'm not sure if that's on jest-ts or something else maybe. Locally I did not get any error. Anyway, I've changed it to || because the variable can only either be a string or undefined anyways at this point.

lukasbach commented 3 years ago

Cool, happy that I could help :)