enriikke / gatsby-gh-pages-action

GitHub Action to build and deploy your Gatsby site to GitHub Pages ❤️🎩
MIT License
295 stars 62 forks source link

Inconsistent tag name results in using old version #9

Closed jasonnutter closed 4 years ago

jasonnutter commented 5 years ago

The README advises using the following uses command:

- uses: enriikke/gatsby-gh-pages-action@v2

The problem is that the latest release is 2.1.1, not v2.1.1, which means using @v2 results in pulling down v2.0.0, instead of 2.1.1.

tmr08c commented 4 years ago

@enriikke are you able to re-tag the non-v prefixed releases with a v?

I tried using @2, to see if it would look for non v-prefixed versions, but it didn't work.

As a workaround I am able to use the branch syntax, and specify master:

- uses: enriikke/gatsby-gh-pages-action@master
enriikke commented 4 years ago

Thank you for the ping @tmr08c! and for the issue @jasonnutter! ✨

I have updated the tags. Would you mind checking and confirming it works on your end? 😃

tmr08c commented 4 years ago

Thanks for the quick update, @enriikke!

I updated my action to use @v2, but it seems like it is still pulling an old version of the action because it fails with the issue that was resolved in https://github.com/enriikke/gatsby-gh-pages-action/pull/6:

Building with: npm run gatsby build 
npm run gatsby build 
npm ERR! missing script: gatsby

I could try adding the minor version (@v2.1), but my understanding of the docs makes me think I shouldn't need to.

Looking at the releases page, it seems like GH now recognizes v2.1.1 should be used because it has the Marketplace tag:

Screen Shot 2019-12-29 at 11 28 04 AM

Interested if others run into the same issue, or if it's something on my end.

jasonnutter commented 4 years ago

I noticed the version field in package.json file hasn't been updated to 2.1.1, probably worth fixing that also.

enriikke commented 4 years ago

Hi @tmr08c and @jasonnutter! Thank you for following up on this. There was a rouge v2 tag that I had forgotten to update which was pointing to an old commit. This should be fixed now! I also updated the package.json version number on master. Let me know if it works on your end so we can close this issue.

Thank you both for all the helpful information and patience. 😃

jasonnutter commented 4 years ago

@enriikke Looks like it's fixed, thanks!