Monekin open icon - Githubissues

enrique-lozano / Monekin

A 100% Open Source app that tries to make personal finances easier. Fast, simple, without ads, without the need for an Internet connection and with a groundbreaking design, that's Monekin.

GNU Affero General Public License v3.0

70 stars 17 forks source link

Monekin open icon #219

Open shinebrillant opened 1 month ago

shinebrillant commented 1 month ago

Prerequisites

[X] I agree to follow the Code of Conduct.
[X] I have searched for existing issues that already report this problem, without success.
[X] I have read the Contributing Guidelines.
[X] I have updated the app to the last released version.

Current Behavior

When Monekin is opened for the first time, the four corners of the icon are cropped.

nsmail-3

Expected Behavior

The corners of the Monekin icon should be rounded.

Steps to Reproduce

Delete the Monekin app in the background of your mobile phone.
Open the Monekin app.

Additional Information

No response

enrique-lozano commented 1 month ago

The icon is cropped in the splash screen, I added the help wanted label to see if someone can help with this, since I don't have time right now to investigate this issue

vincius0000 commented 1 month ago

What OS does this issue occur on? I've ran main branch in Android Pixel emulator and on splash screen the icon is perfectly rounded. I've experimented with some changes as well, but I could see the same result.

Does this issue still persist?

vincius0000 commented 1 month ago

@enrique-lozano this seems to be an issue with Android 12+.

On another Github for MAUI this was raised (https://github.com/dotnet/maui/issues/9886), the issue is better described in following issue https://github.com/dotnet/maui/issues/9794

There are cetain requirements that Icon must follow https://developer.android.com/develop/ui/views/launch/splash-screen#elements

I did experiments on another project - scaling down the icon helped me. Also, I could replicate this here only after Gradle upgrade.

shinebrillant commented 1 month ago

I use pixel 6 pro, the system is android 14, and I still have this problem after upgrading to 15.

enrique-lozano commented 2 weeks ago

Hi @shinebrillant @vincius0000. This is probably fixed in #211, please test this branch if you can and see if the issue still exists.

vincius0000 commented 2 weeks ago

@enrique-lozano I have the same

I would attempt to rebuild the icon files using Android Studio, just to make sure icon follows the requirements for Android 12+. Then in relevant file I would reference ic_launcher_round.xml and if things don't look round, then try to edit launch_background.xml