search

enriquepiatti / Magicento

PHPStorm plugin for Magento developers
115 stars 35 forks source link

[Magento2] Add autocomplete of action classes or even outsource some functionality to php-toolbox plugin #264

Open Koc opened 7 years ago

Koc commented 7 years ago

Hello!

Magento\Framework\App\ActionFactory::create expects any class name which implements \Magento\Framework\App\ActionInterface. So you can add autocomplete of this classes (strings and ::class notations).

But I thing that there are lot of other similar simple cases, when method expects class name of interface implementation. So in my opinion you can not write code for each case but provide json configuration for https://github.com/Haehnchen/idea-php-toolbox plugin (or even maybe contribute to https://github.com/Haehnchen/idea-php-toolbox-json-files). It much easier and faster way than write code in java.

Koc commented 7 years ago

Also you can provide some Magento-specific providers like https://github.com/Haehnchen/idea-php-toolbox/blob/master/src/de/espend/idea/php/toolbox/provider/php/ClassInterfaceProvider.java and end-user of Magicento got availability of writing own json.