Closed makoto closed 2 years ago
Name | Link |
---|---|
Latest commit | bf4dcf963e3eaeeb48805d7db51713fc77e1a874 |
Latest deploy log | https://app.netlify.com/sites/epic-meitner-ba2575/deploys/62713f75f332fd000849d292 |
Deploy Preview | https://deploy-preview-1468--epic-meitner-ba2575.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site settings.
why are empty records not showing "not set" and instead just blank?
We need to think a bit about the best way to decide when to rely on the subgraph; I don't think checking for the resolve
method is the best option. Alternate suggestions:
Use the default list if the subgraph doesn't contain any entries for the name.
Is this always a good approach? I remember that in the ERC20 example token balance can both be on l2 or l1. You could write a resolver where a user can store data on both l1 and l2/offchain. One workaround will be that I always call these default list regardless of subgraph returns the result or not
@Arachnid I made the following two changes.
provider._getResolver
to check if the given name does not have a resolver on its own. https://github.com/ensdomains/ui/pull/160/commits/4c50d22cffec3a739b0290ee15ea965b5a4af9efThe latest updates on your projects. Learn more about Vercel for Git āļø
Name | Status | Preview | Updated |
---|---|---|---|
ens-app | ā Ready (Inspect) | Visit Preview | May 17, 2022 at 9:43PM (UTC) |
NOTE: I had to disable one failing test related to name wrapper. Tracking it separately at https://github.com/ensdomains/ens-app/issues/1500
Demo
https://offchainexample2.surge.sh/name/offchainexample.eth/details
Please connect to Ropsten and you should see address, email, and description fetched from https://offchain-resolver-example.uc.r.appspot.com/ . You can also see the same results from its subdomains such as https://offchainexample2.surge.sh/name/1.offchainexample.eth/details
Features
resolves
functionresolves
functionDependencies
NOTE
Currently
ui
andmock
points to non official repo for testing purposeHow to test locally
Take notes of ENS registry contract address and the private key of the first account
NOTE: Made ttl super long to prevent timeout because our local app time trip to the future when creating the seed data
3.1 clone the repo
3.2 Create seed data
3.3 start the server
Access http://localhost:3000/name/1.offchainexample.eth/details and http://localhost:3000/name/offchainexample.eth/details and see it shows records