search

ensdomains / ens-app

Legacy ENS manager app
https://legacy.ens.domains/
BSD 2-Clause "Simplified" License
225 stars 266 forks source link

bump ens-avatar to 0.2.0 (#1578) #1579

Closed mdtanrikulu closed 1 year ago

mdtanrikulu commented 2 years ago

this will bring arweave support to ens-app

makoto commented 2 years ago

I just tried on preview and getting this error

Screenshot 2022-11-23 at 18 11 37
makoto commented 2 years ago

Just tried on preview using https://github.com/ensdomains/ens-avatar/pull/23/files#diff-8820011ebf3fa085e98a511f62eedb590e4c0b7413e905977f599be3086f09b4R28 as examples but I am getting this error

Screenshot 2022-11-23 at 18 11 37
mdtanrikulu commented 2 years ago

Just tried on preview using https://github.com/ensdomains/ens-avatar/pull/23/files#diff-8820011ebf3fa085e98a511f62eedb590e4c0b7413e905977f599be3086f09b4R28 as examples but I am getting this error

Screenshot 2022-11-23 at 18 11 37

oh good catch! this change tested with NFT's with arweave storage backend, but not raw arweave urls. Added protocol support in this branch

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: bfca0b1
Status: ✅  Deploy successful!
Preview URL: https://675a4ef5.ens-app.pages.dev
Branch Preview URL: https://dev.ens-app.pages.dev

View logs