ensdomains / ens-app

Legacy ENS manager app
https://legacy.ens.domains/
BSD 2-Clause "Simplified" License
224 stars 266 forks source link

Native segwit address support #498

Closed hewigovens closed 5 years ago

hewigovens commented 5 years ago

When I tried to save a native segwit address, I got this error:

image

from https://github.com/ethereum/EIPs/blob/master/EIPS/eip-2304.md, bitcoin or litecoin address is base58check-decoded bytes, this is not always the case

hewigovens commented 5 years ago

Although we can store the witness in raw bytes, but we still need a standard that everyone can follow (P2PKH, P2SH, P2WPKH)

makoto commented 5 years ago

@hewigovens we recently updated our Manager which integrates with https://github.com/ensdomains/address-encoder . Could you let me know if you are still facing the issue?

hewigovens commented 5 years ago

thanks, it's fixed