search

ensdomains / ens-app

Legacy ENS manager app
https://legacy.ens.domains/
BSD 2-Clause "Simplified" License
222 stars 267 forks source link

Issues with subdomains #963

Open nftworld opened 3 years ago

nftworld commented 3 years ago

The first subdomain was created as expected. When I typed "sugarclub" as the name, thats how the subdomain appears in the list. But the next one I created I called "minidcl" but instead of that it shows a 0x address. Any idea why? Screenshot attached. Capture

Also, nothing happens when I click "Save" or "Confirm" when trying to create a Content record for the sugarclub subdomain. Too bad I cant attach a video of this.

jefflau commented 3 years ago

The reason it comes up as a hash, is because the label you used is not inside the preimage database we use to decrypt it. Although I should add it to the localstorage of labels in your own browser. I'll add that as a separate issue.

No confirm box pops up when trying to add the content record? That's definitely a bug, if you could upload a video with the console open that would be fantastic. I'll have a look into it anyway

pertsev commented 3 years ago

I have the same issue. If a subdomain is not a well-known word, it is displayed as sha3 of the word after the subdomain registration.

As a workaround, you can visit app.ens.domains/name/minidcl.ntfworkd.eth and it will be added to your local storage and then displayed in a readable way on the subdomains page.

@jefflau I believe it's possible to add the subdomain into the Localstorage during registration. Could you fix that?

ronnno commented 3 years ago

Having a similar issue - but in my case, adding the preimage to local storage is not enough - i'd like everyone to be able to decipher the label.

is there a way to add labels to the preimage database? a workaround might also do.. i tried re-registering the subdomain but this did not help

makoto commented 3 years ago

it's possible to add the subdomain into the Localstorage during registration I think this is doable. Added "but" label to implement the feature.

stefa2k commented 2 years ago

any update on this? been a while...

ZaK3939 commented 2 years ago

any update about this topic? phidemo_eth

I would like to use subdomain for my usecase. When I call setSubnodeRecord, long strings cause this problem. https://gist.github.com/ZaK3939/cd7129079d660575fbc9924255ae8291