search

ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
588 stars 401 forks source link

fix set error reverse record owner bug #259

Closed ququzone closed 1 year ago

Arachnid commented 1 year ago

What error do you think this is fixing? The fix would allow anyone to set other peoples' reverse records.

ququzone commented 1 year ago

What error do you think this is fixing? The fix would allow anyone to set other peoples' reverse records.

When using register to register a name and the owner parameter value is different from msg.sender, the reverse record to this name will be set to msg.sender. I think should be set to owner.

Arachnid commented 1 year ago

Closing this as it would allow people to set others' reverse records without permission.