ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
572 stars 394 forks source link

Add L2 reverse registrar contract #265

Open jefflau opened 1 year ago

jefflau commented 1 year ago
makoto commented 10 months ago

What is the rational of the reverse registrar having setText which wasn't the case for L1 reverse registrar? Also, if there is a valid reason for it, what's the reason of reverse registrar not having setAddr either?

makoto commented 10 months ago

More of a general observation but do they have any L2 specific traits about these contracts? The majority of the work is to allow registration by signature which is useful on L1 as well. Can we make this as a default name registrar on L1 as well?

makoto commented 9 months ago

You probably need to add function supportsInterface

jefflau commented 9 months ago

You probably need to add function supportsInterface

I think there is already a function there?