ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
572 stars 394 forks source link

Need to update node version in .nvmrc #279

Open subashcs opened 11 months ago

subashcs commented 11 months ago

ISSUE The node version in .nvmrc does not work on Mac OS. Error ( package got@12.1.0 requires node >= 14.16.0) is thrown while trying to install packages with yarn. SOLUTION I would suggest updating the node version in .nvmrc to v16.15.1.

Full cli trace:

ens-contracts ➤  yarn install
yarn install v1.22.19
warning ../../../../../package.json: No license field
[1/4] 🔍  Resolving packages...
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@0.5.5"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
[2/4] 🚚  Fetching packages...
error got@12.1.0: The engine "node" is incompatible with this module. Expected version ">=14.16". Got "14.15.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Mrt3383x38 commented 11 months ago

ISSUE The node version in .nvmrc does not work on Mac OS. Error ( package got@12.1.0 requires node >= 14.16.0) is thrown while trying to install packages with yarn. SOLUTION I would suggest updating the node version in .nvmrc to v16.15.1.

Full cli trace:

ens-contracts ➤  yarn install
yarn install v1.22.19
warning ../../../../../package.json: No license field
[1/4] 🔍  Resolving packages...
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@0.5.5"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
warning Resolution field "js-sha3@0.8.0" is incompatible with requested version "js-sha3@^0.5.7"
[2/4] 🚚  Fetching packages...
error got@12.1.0: The engine "node" is incompatible with this module. Expected version ">=14.16". Got "14.15.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.