While writing some unit tests I was reviewing the ENS contracts for all possible revert() instances and came across an instance with makeCommitment that allows the resolver to be address(0) and setting reverseResolver True will revert as the resolver is address(0).
As i saw there is a check for resolver != address(0) when data is supplied I thought it should be considered a similar/same kind of check.
A flawed frontend can submit commitments which can never register etc.
Not critical or a big deal but:
While writing some unit tests I was reviewing the ENS contracts for all possible revert() instances and came across an instance with makeCommitment that allows the resolver to be address(0) and setting reverseResolver True will revert as the resolver is address(0).
As i saw there is a check for resolver != address(0) when data is supplied I thought it should be considered a similar/same kind of check.
A flawed frontend can submit commitments which can never register etc.