Closed mdtanrikulu closed 7 months ago
Hey @lcfr-eth 👋 unfortunately adding the commitments
interface manually, creates an interface mismatch in here and breaks the CI.
Just to clarify, when I mentioned "unused", I was actually pointing out that Solidity already automatically generates getters for public mappings. From what I've seen, our manual addition isn't really called anywhere in our current code. Although I see your point about why having this getter in the interface makes sense.
I'm still scratching my head over the exact cause of this mismatch. For now, my gut says we should hold off on adding it to the interface until we figure out what's going wrong. If you're up for it, I'd appreciate a fresh set of eyes on this.
You can observe the issue by running;
yarn test test/ethregistrar/TestBulkRenewal.js
before and after function commitments(bytes32) external view returns (uint256);
included into IETHRegistrarController
.
Hi - I don't believe this should be removed... How is it determined that it is "unused" ? Interfaces should cover all public variables/functions IMO. We use this at vision in our UI to verify commitments age etc.
I believe I did the original PR to add this as I found I needed to manually create an interface that included for my own usage instead of using the official ENS interface..
for example running the forge command 'cast interface' on the current ETHRegistrarController includes this:
cast interface 0x253553366Da8546fC250F225fe3d25d0C782303b