ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
565 stars 384 forks source link

fix: universalresolver hybrid onchain/offchain handling #324

Closed TateB closed 6 months ago

TateB commented 6 months ago

previously, a batch call would add non-ENSIP10 encoded calls toextraDatas for onchain calls. extraDatas is used within OffchainLookup, and is directly passed through from a call to a callback, allowing the UR to re-call requests that were already onchain. since the calls in extraDatas were not ENSIP10 encoded, and since calls are not re-encoded in callbacks, this lead to situations where for a hybrid (onchain/offchain calls together) batch call, onchain data would be fetched on callback with the non-ENSIP10 equivalent function.

changes:

technicallykind commented 6 months ago

👀 Tagging myself to be notified on merge