ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
565 stars 384 forks source link

Default reverse resolver #335

Closed makoto closed 4 months ago

makoto commented 6 months ago
makoto commented 6 months ago

To sum up about the events,

Hence both events should be defined at ISignatureReverseResolver

makoto commented 5 months ago

I think it should be incorporated, there's no reason for it to be a separate parameter here. at https://github.com/ensdomains/ens-contracts/pull/335#discussion_r1543548879 , addr is used to derive node at bytes32 node = _getNamehash(addr); line 73 @Arachnid

Arachnid commented 5 months ago

I think it should be incorporated, there's no reason for it to be a separate parameter here. at https://github.com/ensdomains/ens-contracts/pull/335#discussion_r1543548879 , addr is used to derive node at bytes32 node = _getNamehash(addr); line 73 @Arachnid

Line 73 of what file? I can't see anywhere that would require this to be a separate parameter to the outer signature.