Closed makoto closed 4 months ago
To sum up about the events,
ReverseClaimed
are called by both L2ReverseRegistrar
and SignatureReverseResolver
(because setNameForAddrWithSignatureAndOwnable
needs to pass contractAddress
as the argument)NameChanged
is only called by SignatureReverseResolver
.Hence both events should be defined at ISignatureReverseResolver
I think it should be incorporated, there's no reason for it to be a separate parameter here.
at https://github.com/ensdomains/ens-contracts/pull/335#discussion_r1543548879 , addr
is used to derive node
at bytes32 node = _getNamehash(addr);
line 73 @Arachnid
I think it should be incorporated, there's no reason for it to be a separate parameter here. at https://github.com/ensdomains/ens-contracts/pull/335#discussion_r1543548879 , addr is used to derive node at bytes32 node = _getNamehash(addr); line 73 @Arachnid
Line 73 of what file? I can't see anywhere that would require this to be a separate parameter to the outer signature.