ensdomains / ens-contracts

The core contracts of the ENS protocol
https://ens.domains/
MIT License
572 stars 394 forks source link

TypeError: Member "isContract" not found or not visible after argument-dependent lookup in address. #383

Open x5engine opened 2 weeks ago

x5engine commented 2 weeks ago

Using isContract causes an issue compiling the wrapper!

TypeError: Member "isContract" not found or not visible after argument-dependent lookup in address. --> .deps/npm/@ensdomains/ens-contracts/contracts/wrapper/ERC1155Fuse.sol:344:13: | 344 | if (to.isContract()) { | ^^^^^^^^^^^^^

https://github.com/ensdomains/ens-contracts/blob/92b6a89b0c0914f3b1a20a9e7ac82d49d1fb9fcf/contracts/wrapper/ERC1155Fuse.sol#L344

Also it is not advisable to use it at all but use tx.origin

https://despac1to.medium.com/carefully-use-openzeppelins-address-iscontract-msg-sender-4136cc6ff66d

x5engine commented 1 week ago

Hello 👋

New answer on this?