ensdomains / ens-metadata-service

https://metadata.ens.domains
MIT License
72 stars 61 forks source link

Avatar doesn't display on very long ENS names #122

Open cthulu-dot-eth opened 2 years ago

cthulu-dot-eth commented 2 years ago

Avatars set on ENS names that are very long don't have their backgrounds generated by the metadata service.

For example, this ENS name has an avatar set which can be confirmed via the metadata service and manager app: "ocanadaourhomeandnativelandtruepatriotloveinallofuscommandwithglowingheartsweseetheerisethetruenorthstrongandfreefromfarandwideocanadawestandonguardfortheegodkeepourlandgloriousandfreeocanadawestandonguardfortheeocanadawestandonguardforthee.eth" [manager app] [metadata service]

However, the background isn't generated for it: 6a0e13780c2884be5a0281925bc70bd4

The link in the metadata service background image field returns: "There is no avatar set under given address" [metadata service background image]

Sexadegen commented 2 years ago

This is a significant problem for me right now. I have 20+ domains where the names are long enough to get truncated and the avatar doesn't show as a result. It's made worse by the fact that for long names such as the one in the image, sometimes it's hard to know exactly what the name is, where this could be resolved if the avatar was used to help explain the name rather than just be used for marketing purposes.

While this might seem like an edge case - after all, no-one is going to type in a name that long, this is not about using the ENS as an address, it is about extending the use of ENS to be used purely as a collectable item and with that in mind I'd suggest that it should get a suitable level of consideration.