avatar record doesn't work for domains with unicode characters

ensdomains / ens-metadata-service

MIT License

70 stars 61 forks source link

avatar record doesn't work for domains with unicode characters #50

Closed scottweston closed 1 year ago

scottweston commented 2 years ago

getResolver() is returning null for domains containing unicode here:

https://github.com/ensdomains/ens-metadata-service/blob/dd6a1b1608eac9219d6aa9fc6baba05b7e1a6694/src/avatar.ts#L258

This is resulting in domains with otherwise correctly set avatar text fields not working as intended.

e.g. https://metadata.ens.domains/mainnet/avatar/%F0%9F%91%91scott.eth

lucashenning commented 2 years ago

+1 - same issue with a unicode domain not resolving:

this works: https://app.ens.domains/name/lucas%F0%9F%9A%80.eth/details
this doesn't https://metadata.ens.domains/mainnet/avatar/lucas%F0%9F%9A%80.eth/meta

stronk-dev commented 2 years ago

I am experiencing this issue with one of my ENS domains: https://metadata.ens.domains/mainnet/avatar/livepeer%F0%9F%9A%80%F0%9F%8C%91.eth/meta

Interestingly enough 1inch does show the icon, but uniswap, opensea and app.ens aren't able to load the image

benpercifield commented 2 years ago

i've set the avatar for ✨ben✨.eth 4 times now lol

doing a NFT didnt work bc I tried to set videos so thats a separate problem nbd
Reached out to support for help and was told I can do an IPFS hash in addition to NFTs
doing an IPFS hash didnt work
this is the IPFS hash i used: ipfs://QmU2qw9pti3cA95dva7cGyMFBY6ra98cGzFjuaYsqwSeKt

Thank you for making emoji names work! <3

mdtanrikulu commented 1 year ago

after ethers been updated, I am seeing all of the names listed here are working. only ✨ben✨.eth has an issue with the NFT, but it appears to be on the NFT contract side rather than metadata service.

I am getting call_exception when try to get metadata of the NFT from it's own contract;

using another NFT, or contacting with the team of current set NFT may help solving.