ensdomains / ens-metadata-service

https://metadata.ens.domains
MIT License
72 stars 61 forks source link

Seemingly valid names are being reported as invalid by metadata service #71

Closed serenae-fansubs closed 2 months ago

serenae-fansubs commented 2 years ago

This name appears to be valid: https://app.ens.domains/name/%E2%8C%90%E2%97%A8%E2%80%90%E2%97%A8.eth/details

⌐◨‐◨.eth

The eth-ens-namehash.normalize method also doesn't throw any errors:

require("@ensdomains/eth-ens-namehash").normalize('⌐◨‐◨.eth')

⌐◨‐◨.eth

Yet the metadata service is reporting that as invalid: https://metadata.ens.domains/mainnet/0x57f1887a8BF19b14fC0dF6Fd9B2acc9Af147eA85/29374690480179650074424749477986431727881478513446796185670528844166493337335/image

image

Pitter108 commented 2 years ago

This is answer from opensea customer service

Hi there,  Thanks for reaching out. I apologize for any inconvenience this may have caused. I understand it can be quite confusing if your ENS is not showing at OpenSea. Don't worry, I’d be happy to clarify why your ENS name is not visible on OpenSea.  ENS allows users to register names that are not valid. For example, they may contain zero-width spacing between characters or invalid characters altogether. Because of this, ENS will remove the names once their system identifies them.  It’s important to note that OpenSea doesn’t control ENS — instead, OpenSea is simply a window into viewing what’s currently in your wallet. If ENS removes something or marks it invalid, it’s not something OpenSea can change. We do, however, display a warning message on ENS names that we believe to be at risk of removal.  With that said, if you believe they incorrectly removed or marked your ENS as invalid, we recommend reaching out to them. Once it’s been corrected, OpenSea will start displaying the name again within your wallet.  Here’s the website to contact ENS directly: https://docs.ens.domains/frequently-asked-questions I know this can be confusing, so please let me know if I can help with anything else. Take care! 😊️

rocketinspirit commented 2 years ago

Hey there, I was directed to this page by ENS support on twitter regarding the same issue of having an "invalid" names being delisted or not being visible on Opensea. One of the names I registered contained characters from the Japanese keyboard and others contained emoji's. I received the same message Pitter108 received after contacting Opensea. This is an example of one of the names. https://app.ens.eth.limo/#/name/%E3%82%A8%E3%83%AC%E3%83%96%E3%83%BC.eth/details

I'm glad to know it has been something that is being worked on and there will be a resolution for this soon. It's also helpful to know there is a tool that I can use to check names with non ASCII characters, which I'll try to use in the future.

Good luck!

Pitter108 commented 2 years ago

Any update friends? I still didn't receive those registered name.

toemm commented 2 years ago

Having the same issues and found this thread on discord. Payed around 600$ in eth for a 3 character domain which is delisted on Opensea after.. Many people on Discord having this issue for months. A fix or update is needed here before more people lose money...

Pitter108 commented 2 years ago

Is there anybody to fix our problem?

ZeroPie commented 2 years ago

This domains

While browsing around on OS i came across this domain and observed it contains an ⚠️ https://opensea.io/assets/0x57f1887a8bf19b14fc0df6fd9b2acc9af147ea85/641843354079041929038989821364773426388122798518459335069695137152283574237

Screenshot 2022-05-07 at 12 16 10

What brought me to the idea of having some sort of flag to make it evident that some domains contain special characters. If i understand correctly os is just trying to prevent scams. What if we had a mechanism to add a flag to differentiate domains with non discernable characters?

This makes them tradeable, this makes them distuinguishable, everyone is happy :)?

Pitter108 commented 2 years ago

This is another answer from opensea customer service

Hello,

Thank you for patiently waiting for our response. How are you doing? I hope you are well.

I am very sorry to hear that your ENS domains doesn't show in OpenSea. I understand that this has been frustrating, and I do apologize for the inconvenience it has caused. Rest assured that I will do my best to clarify why your ENS name isn’t visible on OpenSea.

Taking a look at the item’s history, your ENS name was delisted under our Terms of Service, meaning it will no longer appear on our platform. I understand this can be really disappointing.

If an ENS name violates our Terms of Service, or we receive a DMCA request, we may be obligated to remove it from OpenSea. However, please rest assured that your domain name is still valid, even if we aren’t able to display it on our platform. The ENS is still in your wallet, and can be seen on other platforms for sale. We can’t confirm whether it violates the Terms of Service of other websites.    I know that this is not the response you are expecting to hear, and I understand the disappointment. I wish I can provide you with a better resolution, so if I can help you in another way, please let me know. Don't hesitate to reach out back to me, I'm just here for you.

Pitter108 commented 2 years ago

What's that mean ☝. Is that means we lost our money ? How can I sale my nft ? Any response I really appreciate

sanskaryo commented 2 years ago

I think if OS continues to delist domains like this then ens should also update its list of valid domains and remove those which do not fulfill the terms and conditions of exchanges or just show a warning sign at the time of minting

sanskaryo commented 2 years ago

https://adraffy.github.io/ens-normalize.js/test/resolver.html#%E3%83%AA%E3%83%B4%E3%82%A1%E3%82%A4%E3%83%BB%E3%82%A2%E3%83%83%E3%82%AB%E3%83%BC%E3%83%9E%E3%83%B3 リヴァイ・アッカーマン is showing normalized but still not appering on OS , is there any other way to check normalization before minting a domain

toemm commented 2 years ago

This is another answer from opensea customer service

Hello,

Thank you for patiently waiting for our response. How are you doing? I hope you are well.

I am very sorry to hear that your ENS domains doesn't show in OpenSea. I understand that this has been frustrating, and I do apologize for the inconvenience it has caused. Rest assured that I will do my best to clarify why your ENS name isn’t visible on OpenSea.

Taking a look at the item’s history, your ENS name was delisted under our Terms of Service, meaning it will no longer appear on our platform. I understand this can be really disappointing.

If an ENS name violates our Terms of Service, or we receive a DMCA request, we may be obligated to remove it from OpenSea. However, please rest assured that your domain name is still valid, even if we aren’t able to display it on our platform. The ENS is still in your wallet, and can be seen on other platforms for sale. We can’t confirm whether it violates the Terms of Service of other websites.    I know that this is not the response you are expecting to hear, and I understand the disappointment. I wish I can provide you with a better resolution, so if I can help you in another way, please let me know. Don't hesitate to reach out back to me, I'm just here for you.

Can a dev confirm that this is true? Meaning with the update OS doesn't list the domain anymore?

pho4 commented 2 years ago

https://adraffy.github.io/ens-normalize.js/test/resolver.html#%E3%83%AA%E3%83%B4%E3%82%A1%E3%82%A4%E3%83%BB%E3%82%A2%E3%83%83%E3%82%AB%E3%83%BC%E3%83%9E%E3%83%B3 リヴァイ・アッカーマン is showing normalized but still not appering on OS , is there any other way to check normalization before minting a domain

based on what i've read so far around on discord and on gitbub, the character "ー" got caught up in one of the latest updates which renders all names with that character as 'invalid'. hopefully the ens team is willing to look at that character specifically since it bricks a chunk of japanese characters.

delbagir commented 2 years ago

it seems that even on my metamask, under the ENS assets, i dont see the ens domain i registered. can we have an update on this?

SkuIlz commented 2 years ago

I bought 3 digit domain, using non character. When I check the domain it says valid and registered by me. But its delisted in opensea and it says invalid address with red background ![Uploading FE6D481D-214A-45B8-943A-D2F630BE14EE.png…]()

SkuIlz commented 2 years ago

4ACD7963-F913-4B94-B4FB-1244C3F22012

yoleyo commented 2 years ago

and we all waiting for a fix, but nothin seems to be coming

serenae-fansubs commented 2 years ago

It is coming! I assure you, devs have been hard at work on this: https://discuss.ens.domains/t/ens-name-normalization/8652/128

Not all names will become valid after the change though! The code is not final, but this live demo site can be used to get a good idea of what will be valid/invalid per the metadata: https://adraffy.github.io/ens-normalize.js/test/resolver.html

SkuIlz commented 2 years ago

It is coming! I assure you, devs have been hard at work on this: https://discuss.ens.domains/t/ens-name-normalization/8652/128

Not all names will become valid after the change though! The code is not final, but this live demo site can be used to get a good idea of what will be valid/invalid per the metadata: https://adraffy.github.io/ens-normalize.js/test/resolver.html

Hello thank you for reply , i checked live link you sent, I entered my domain which had delisted from opensea “aрe.eth” the “р” alphabet is different thats why they delisted it from OS. Do you think they will fix it ? ![Uploading 86B436CD-C4D1-428E-B3C0-6333C836568B.png…]()

SkuIlz commented 2 years ago

BE60B508-E13A-4518-8422-89B5D4E81201

Shark43 commented 2 years ago

hi, i bought some JP ENS: ユクシー.eth 0x17595d4ed4e2d0af4ce013560fa2884f8efa38234cd0622fec0645c7e891a257 https://metadata.ens.domains/mainnet/0x57f1887a8bf19b14fc0df6fd9b2acc9af147ea85/19921806114804879714177476371129274652135542314822121026147215006123759778213 マーシャドー.eth 0xaa2dc94305a7a5677166c8564f95e269270dfcc1484b6f2925f889f3662157df https://metadata.ens.domains/mainnet/0x57f1887a8bf19b14fc0df6fd9b2acc9af147ea85/70014084200189111013728177536713399682074110973574252266516382054367630835630

i think the problem is with this character 'ー' that is used in most of JP words. hope you can fix this character

with https://adraffy.github.io/ens-normalize.js/test/resolver.html#%E3%83%A6%E3%82%AF%E3%82%B7%E3%83%BC say it normalized but with the main api not

Swavevince commented 2 years ago

any progress? still waiting on my n°1.eth , n°2.eth, n°3eth,.. n°5eth, n°7eth n°9eth n°10.eth n°20.eth and n°50.eth??

⚠️ Disallowed character "{B0}" any news on when it will get fixed?

coltron-code commented 2 years ago

@mdtanrikulu Is there a status update on this issue?

I notice we're still receiving support tickets and forum inquires about this.

mdtanrikulu commented 2 years ago

@mdtanrikulu Is there a status update on this issue?

I notice we're still receiving support tickets and forum inquires about this.

Hi @coltron-code and everyone wondering the progress in here.

We patched ens-app as in same fashion as metadata service to prevent future delisting issues. Currently both services work with ens-validation library, which means no other name registered trough ens-app will be delisted from now on.
Of course this is not an ultimate solution, since the problem is in core of ens-validation library itself, but a measure to keep the issue under control in some extent.

The main work and discussion regarding normalization continues here.

When the normalization spec settles, we will be using this standard in all services asap.

mdtanrikulu commented 2 months ago

since the normalization spec is settled, and reimbursement for the invalid names are done, closing this issue.