search

ensdomains / ens

Implementations for ENS core functionality: The registry, registrars, and public resolvers.
https://ens.domains/
BSD 2-Clause "Simplified" License
1.16k stars 511 forks source link

Change testrpc dependency for ganache-cli. #370

Open jurajpiar opened 3 years ago

jurajpiar commented 3 years ago

Currently this uses an old testrpc dependency, which should be changed to ganache-cli. One of the issues this would resolve is related to the testrpc package having webpack as a direct dependency, which causes problems in projects that require webpack of higher version. Ganache-cli solves this by putting its webpack dep. in dev dependencies.

I've ran the tests with ganach-cli without failing, so if you like I can create a PR.

sambacha commented 3 years ago

an example of how this is creating weird dependencies:

hardhat-template@0.0.1
└─┬ ethereum-waffle@3.3.0
  └─┬ @ethereum-waffle/provider@3.3.2
    └─┬ @ethereum-waffle/ens@3.2.4
      └─┬ @ensdomains/ens@0.4.5
        └── testrpc@0.0.1
chancehudson commented 2 years ago

This is a very simple fix that is causing real issues in downstream projects. Could someone review #334? The problem is literally solved.