ensdomains / ensjs-v2

Javascript bindings for the Ethereum Name Service
208 stars 122 forks source link

Add support for web3 1.0. #17

Open Arachnid opened 6 years ago

sohkai commented 6 years ago

A note that web3.js@1.0.0-beta.34 breaks compatibility with wss connections and you may want to downgrade to beta.33 until it's fixed.

sohkai commented 6 years ago

Apparently web3.js@1.0.0-beta.35 fixes the wss issues :).

vs77bb commented 6 years ago

@Arachnid Thoughts on a bounty here? Someone made a Gitcoin Request for it 🙂 cc @StevenJNPearce

makoto commented 6 years ago

This may solve the issue.

  provider.sendAsync = provider.send;
  var ens = new ENS(provider);

Not sure how I patch this as there is no call to sendAsync function in the ensjs itself

adamcohen commented 6 years ago

For anyone that arrives here from google and is receiving the following error with ethereum-ens 0.7.4 and web3.js@1.0.0-beta36:

Unhandled rejection TypeError: this.provider.sendAsync is not a function

The solution provided by @makoto solved it for me

RobertoC27 commented 5 years ago

I'm getting an undefined object when instantiating ensjs with web3@beta.35