search

ensdomains / ensjs-v2

Javascript bindings for the Ethereum Name Service
208 stars 122 forks source link

Documentation typo #38

Open ellis2323 opened 5 years ago

ellis2323 commented 5 years ago

it is related to this page https://docs.ens.domains/dapp-developer-guide/resolving-names

when you lookup the reverse, you should not compare address with = operator for the ethers library. If you provide lowercase address, it won't work.

You could get the checksum version with:

var address = ethers.utils.getAddress('0x1234...');
Arachnid commented 5 years ago

Thanks! I've removed that bit entirely, since ethers.js already checks forward resolution internally.

ellis2323 commented 5 years ago

Perfect. I have finished the integration in whois0x.io. Thx