search

ensdomains / ethregistrar

BSD 2-Clause "Simplified" License
94 stars 55 forks source link

Prepare ETHRegistrar for 3-letter (and longer) names #40

Closed ricmoo closed 5 years ago

ricmoo commented 5 years ago

Prepare the ETHRegistrar for 3-letter (and longer) names.

Also adds the ability for a one-shot configuration, setting up a resolver and resolved address at commitment time for the registration call.

Note:

The test cases require this line in resolvers to be changed to ^0.5.0.

Updating the version of solc in ethregistrar breaks the test suite (seems there is a breaking change in the solc output that truffle depends on?), so pulling the resolvers package in breaks things because that file indicates it needs a version of the compiler newer than ethregistrar is able to use.

For a quick fix, you can update the value in the node_modules/, but ideally truffle needs to support 0.5.8 (or someone who better understands truffle can figure out what I couldn't :)) or less-ideally, change the AddrProfile pragma to ^0.5.0.

Arachnid commented 5 years ago

@decanus Could use your eyeballs on this too.

ricmoo commented 5 years ago

I've made the suggested changes as well as updated the resolvers package and submitted a PR. It will need to be merged and these tests re-triggered to pass.

Thanks! :)

ricmoo commented 5 years ago

Awesome. Looks good to me. :)