ensdomains / ethregistrar

BSD 2-Clause "Simplified" License
92 stars 55 forks source link

Reclaim before transfer #45

Closed makoto closed 4 years ago

makoto commented 4 years ago

The current implementation leaves the controller (aka the owner of the registry, deed owner) to the contract address of ETHRegistrarController (NOTE: these two are super confusing. We definitely need to change the controller on the UI to admin or operator or something else besides "controller") and prevents from the user from changing addresses or any other fields until they set it to themselves.

Screenshot 2019-11-06 at 14 12 57

The fix will claim it to the user so that the user can start setting records immediately after the registration.

Screenshot 2019-11-06 at 14 40 27

Good job on @jefflau for catching this error on the integration test of ens-app!

cc @ricmoo